Fix problem in test for pylint

README.rst

@@ -170,7 +170,7 @@ Quickstart
 Для проверки pylint используем:
 -------------------------------
 
-pylint --django-settings-module=access_controller.access_controller.settings ../access_controller (каталог, где лежит проект)
+pylint ../access_controller_new (каталог, где лежит проект)
 
 Для приведения файлов к стандарту PEP8 используем:
 --------------------------------------------------

access_controller/settings.py

@@ -12,8 +12,6 @@ https://docs.djangoproject.com/en/3.1/ref/settings/
 import os
 
 from pathlib import Path
-
-
 from dotenv import load_dotenv
 
 # Build paths inside the project like this: BASE_DIR / 'subdir'.

main/tests.py

@@ -1,3 +1,8 @@
+"""
+Тестирование работы программы.
+"""
+
+
 import random
 from unittest.mock import patch, Mock
 
@@ -218,7 +223,8 @@ class MakeEngineerTestCase(UsersBaseTestCase):
         """
         self.admin_client.post(
             reverse_lazy('control'),
-            data={'users': [get_user_model().objects.get(email=self.light_agent).userprofile.id], 'engineer': 'engineer'}
+            data={'users': [get_user_model().objects.get(email=self.light_agent).userprofile.id],
+                  'engineer': 'engineer'}
         )
         call_list = zenpy_mock.update_user.call_args_list
         mock_object = call_list[0][0][0]
@@ -356,7 +362,8 @@ class MakeLightAgentTestCase(UsersBaseTestCase):
         """
         self.admin_client.post(
             reverse_lazy('control'),
-            data={'users': [get_user_model().objects.get(email=self.engineer).userprofile.id], 'light_agent': 'light_agent'}
+            data={'users': [get_user_model().objects.get(email=self.engineer).userprofile.id],
+                  'light_agent': 'light_agent'}
         )
         call_list = zenpy_mock.update_user.call_args_list
         mock_object = call_list[0][0][0]
@@ -447,7 +454,8 @@ class PasswordResetTestCase(UsersBaseTestCase):
         Проверяет отсутствие отправки письма о смене пароля.
         """
         with self.settings(EMAIL_BACKEND=self.email_backend):
-            resp = self.agent_client.post(reverse_lazy('password_reset'), data={'email': self.light_agent + str(random.random())})
+            resp = self.agent_client.post(reverse_lazy('password_reset'),
+                                          data={'email': self.light_agent + str(random.random())})
         self.assertRedirects(resp, reverse('password_reset_done'))
         self.assertEqual(resp.status_code, 302)
         self.assertEqual(len(mail.outbox), 0)
@@ -635,11 +643,11 @@ class GetTicketsTestCase(UsersBaseTestCase):
 
     @patch('main.views.zenpy')
     @patch('main.views.get_tickets_list_for_group')
-    def test_take_zero_tickets(self, TicketsMock, zenpy_mock):
+    def test_take_zero_tickets(self, tickets_mock, zenpy_mock):
         """
         Функция проверки попытки назначения нуля тикета на engineer.
         """
-        TicketsMock.return_value = [Mock()] * 3
+        tickets_mock.return_value = [Mock()] * 3
         zenpy_mock.get_user.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['engineer'])
         self.engineer_client.post(reverse('work_get_tickets'), data={'count_tickets': 0})
         tickets = zenpy_mock.update_tickets.call_args[0][0]
@@ -730,9 +738,8 @@ class LoggingTestCase(UsersBaseTestCase):
 
     @staticmethod
     def get_file_output():
-        file = open('logs/logs.csv', 'r')
+        with open('logs/logs.csv', 'r') as file:
             file_output = file.readlines()[-1]
-        file.close()
         return file_output
 
     def test_engineer_with_admin(self):

main/views.py

@@ -453,5 +453,8 @@ def statistic_page(request: WSGIRequest) -> HttpResponse:
     context['form'] = form
     return render(request, 'pages/statistic.html', context)
 
-def registration_failed(request):
+def registration_failed(request: WSGIRequest) -> HttpResponse:
+    """
+    Функция отображения страницы "Регистрация закрыта".
+    """
     return render(request, 'pages/registration_failed.html')