Merge branch 'develop' into feature/registration_bug

# Conflicts:
#	main/views.py

main/extra_func.py

@@ -1,3 +1,4 @@
+import logging
 import os
 from datetime import timedelta, datetime, date
 
@@ -7,6 +8,7 @@ from django.utils import timezone
 from zenpy import Zenpy
 from zenpy.lib.exception import APIException
 
+
 from access_controller.settings import ZENDESK_ROLES as ROLES, ONE_DAY, ZENDESK_GROUPS, SOLVED_TICKETS_EMAIL
 from main.models import UserProfile, RoleChangeLogs, UnassignedTicket, UnassignedTicketStatus
 
@@ -139,7 +141,7 @@ class ZendeskAdmin:
             raise ValueError('invalid access_controller`s login data')
 
 
-def update_role(user_profile: UserProfile, role: str) -> UserProfile:
+def update_role(user_profile: UserProfile, role: int) -> UserProfile:
     """
     Функция меняет роль пользователя.
 
@@ -162,12 +164,6 @@ def make_engineer(user_profile: UserProfile, who_changes: User) -> UserProfile:
     :param user_profile: Профиль пользователя
     :return: Вызов функции **update_role** с параметрами: профиль пользователя, роль "engineer"
     """
-    RoleChangeLogs.objects.create(
-        user=user_profile.user,
-        old_role=user_profile.custom_role_id,
-        new_role=ROLES['engineer'],
-        changed_by=who_changes
-    )
     update_role(user_profile, ROLES['engineer'])
 
 
@@ -191,13 +187,6 @@ def make_light_agent(user_profile: UserProfile, who_changes: User) -> UserProfil
             ticket.assignee = None
             ticket.group = ZendeskAdmin().get_group(ZENDESK_GROUPS['buffer'])
         ZendeskAdmin().admin.tickets.update(ticket)
-
-    RoleChangeLogs.objects.create(
-        user=user_profile.user,
-        old_role=user_profile.custom_role_id,
-        new_role=ROLES['light_agent'],
-        changed_by=who_changes
-    )
     update_role(user_profile, ROLES['light_agent'])
 
 
@@ -274,7 +263,7 @@ def check_user_auth(email: str, password: str) -> bool:
     return True
 
 
-def update_user_in_model(profile: UserProfile, zendesk_user: User) -> UserProfile:
+def update_user_in_model(profile: UserProfile, zendesk_user: User):
     """
     Функция обновляет профиль пользователя при изменении данных пользователя на Zendesk.
 
@@ -607,3 +596,72 @@ class StatisticData:
         """
         self.statistic.clear()
         self.fill_daterange(self.start_date, self.end_date + timedelta(days=1), 0)
+
+
+class DatabaseHandler(logging.Handler):
+    def __init__(self):
+        logging.Handler.__init__(self)
+
+    def emit(self, record):
+        database = RoleChangeLogs()
+        users = record.msg
+        if users[1]:
+            user = users[0]
+            admin = users[1]
+        elif not users[1]:
+            user = users[0]
+            admin = users[0]
+        database.name = user.name
+        database.user = user.user
+        database.changed_by = admin.user
+        if user.custom_role_id == ROLES['engineer']:
+            database.old_role = ROLES['light_agent']
+        elif user.custom_role_id == ROLES['light_agent']:
+            database.old_role = ROLES['engineer']
+        database.new_role = user.custom_role_id
+        database.save()
+
+
+class CsvFormatter(logging.Formatter):
+    def __init__(self):
+        logging.Formatter.__init__(self)
+
+    def format(self, record):
+        users = record.msg
+        if users[1]:
+            user = users[0]
+            admin = users[1]
+        elif not users[1]:
+            user = users[0]
+            admin = users[0]
+        msg = ''
+        msg += user.name
+        if user.custom_role_id == ROLES['engineer']:
+            msg += ',engineer,'
+        elif user.custom_role_id == ROLES['light_agent']:
+            msg += ',light_agent,'
+        time = str(timezone.now().today())
+        msg += time[:16]
+        msg += ','
+        msg += admin.name
+        return msg
+
+
+def log(user, admin=0):
+    """
+    Осуществляет запись логов в базу данных и csv файл
+    :param admin:
+    :param user:
+    :return:
+    """
+    users = [user, admin]
+    logger = logging.getLogger('MY_LOGGER')
+    if not logger.hasHandlers():
+        dbhandler = DatabaseHandler()
+        csvformatter = CsvFormatter()
+        csvhandler = logging.FileHandler('logs/logs.csv', "a")
+        csvhandler.setFormatter(csvformatter)
+        logger.addHandler(dbhandler)
+        logger.addHandler(csvhandler)
+    logger.setLevel('INFO')
+    logger.info(users)

main/serializers.py

@@ -1,6 +1,7 @@
 from django.contrib.auth.models import User
 from rest_framework import serializers
 from main.models import UserProfile
+from access_controller.settings import ZENDESK_ROLES
 
 
 class UserSerializer(serializers.HyperlinkedModelSerializer):
@@ -13,9 +14,25 @@ class UserSerializer(serializers.HyperlinkedModelSerializer):
 
 
 class ProfileSerializer(serializers.HyperlinkedModelSerializer):
-    """Сериализатор для модели профиля пользователя"""
+    """Класс serializer для модели профиля пользователя"""
     user = UserSerializer()
 
     class Meta:
         model = UserProfile
         fields = ['user', 'id', 'name', 'zendesk_role']
+
+
+class ZendeskUserSerializer(serializers.Serializer):
+    """Класс serializer для объектов пользователей из zenpy"""
+    name = serializers.CharField()
+    zendesk_role = serializers.SerializerMethodField('get_zendesk_role')
+    email = serializers.EmailField()
+
+    @staticmethod
+    def get_zendesk_role(obj):
+        if obj.custom_role_id == ZENDESK_ROLES['engineer']:
+            return 'engineer'
+        elif obj.custom_role_id == ZENDESK_ROLES['light_agent']:
+            return 'light_agent'
+        else:
+            return "empty"

main/templates/pages/adm_ruleset.html

@@ -34,7 +34,7 @@
         <h6 class="table-title">Список сотрудников</h6>
 
         {% block table %}
-        <table class="light-table">
+        <table class="table table-dark light-table">
 
             <thead>
               <th>Name</th>
@@ -42,8 +42,8 @@
               <th>Role</th>
               <th>Checked</th>
             </thead>
-            <tbody id="tbody">
-            </tbody>
+            <tbody id="tbody"></tbody>
+
         </table>
         <p id="loading">Данные загружаются...</p>
         {% endblock %}

main/views.py

@@ -1,11 +1,15 @@
+import logging
+import os
+from datetime import datetime
+
 from smtplib import SMTPException
 
 from django.contrib import messages
 from django.contrib.auth.decorators import login_required
-from django.contrib.auth.forms import PasswordResetForm
 from django.contrib.auth.mixins import LoginRequiredMixin, PermissionRequiredMixin
 from django.contrib.auth.models import User, Permission
 from django.contrib.auth.tokens import default_token_generator
+from django.contrib.auth.forms import PasswordResetForm
 from django.contrib.auth.views import LoginView
 from django.contrib.contenttypes.models import ContentType
 from django.contrib.messages.views import SuccessMessageMixin
@@ -24,9 +28,9 @@ from zenpy.lib.api_objects import User as ZenpyUser
 from access_controller.settings import EMAIL_HOST_USER, ZENDESK_ROLES, ZENDESK_MAX_AGENTS, ZENDESK_GROUPS
 from main.extra_func import check_user_exist, update_profile, get_user_organization, \
     make_engineer, make_light_agent, get_users_list, update_users_in_model, count_users, \
-    StatisticData, ZendeskAdmin
+    StatisticData, log, ZendeskAdmin
 from main.forms import AdminPageUsers, CustomRegistrationForm, CustomAuthenticationForm, StatisticForm
-from main.serializers import ProfileSerializer
+from main.serializers import ProfileSerializer, ZendeskUserSerializer
 from .models import UserProfile
 
 
@@ -197,6 +201,7 @@ def user_update(zenpy_user: User, admin: User, request: WSGIRequest) -> UserProf
 
     admin.users.update(zenpy_user)
     request.user.userprofile.role = "agent"
+    request.user.userprofile.custom_role_id = zenpy_user.custom_role_id
     request.user.userprofile.save()
     messages.success(request, "Права были изменены")
 
@@ -214,6 +219,7 @@ def work_hand_over(request: WSGIRequest) -> HttpResponseRedirect:
     if zenpy_user.custom_role_id == ZENDESK_ROLES['engineer']:
         zenpy_user.custom_role_id = ZENDESK_ROLES['light_agent']
         user_update(zenpy_user, admin, request)
+        log(request.user.userprofile)
     return HttpResponseRedirect(reverse('work', args=(request.user.id,)))
 
 
@@ -229,10 +235,14 @@ def work_become_engineer(request: WSGIRequest) -> HttpResponseRedirect:
     if zenpy_user.custom_role_id == ZENDESK_ROLES['light_agent']:
         zenpy_user.custom_role_id = ZENDESK_ROLES['engineer']
         user_update(zenpy_user, admin, request)
+        log(request.user.userprofile)
     return HttpResponseRedirect(reverse('work', args=(request.user.id,)))
 
 
-def main_page(request):
+def main_page(request: WSGIRequest) -> HttpResponse:
+    """
+    Функция переадресации на главную страницу.
+    """
     return render(request, 'pages/index.html')
 
 
@@ -278,10 +288,18 @@ class AdminPageView(LoginRequiredMixin, PermissionRequiredMixin, SuccessMessageM
         """
         for user in users:
             make_engineer(user, self.request.user)
+            log(user, self.request.user.userprofile)
 
     def make_light_agents(self, users):
+        """
+        Функция проходит по списку пользователей, проставляя статус "light agent".
+
+        :param users: Список пользователей
+        :return: Обновленный список пользователей
+        """
         for user in users:
             make_light_agent(user, self.request.user)
+            log(user, self.request.user.userprofile)
 
     def get_context_data(self, **kwargs) -> dict:
         """
@@ -308,15 +326,34 @@ class UsersViewSet(viewsets.ReadOnlyModelViewSet):
     serializer_class = ProfileSerializer
 
     def list(self, request, *args, **kwargs):
-        users = update_users_in_model().values
-        count = count_users(users)
+        users = update_users_in_model()
+        count = count_users(users.values)
         profiles = UserProfile.objects.filter(role='agent')
         serializer = self.get_serializer(profiles, many=True)
-        return Response({
+        res = {
             'users': serializer.data,
             'engineers': count[0],
-            'light_agents': count[1]
-        })
+            'light_agents': count[1],
+            "zendesk_users": self.get_zendesk_users(self.choose_users(users.values, profiles))
+        }
+        return Response(res)
+
+    @staticmethod
+    def choose_users(zendesk, model):
+        users = []
+        for zendesk_user in zendesk:
+            if zendesk_user.name not in [user.name for user in model]:
+                users.append(zendesk_user)
+        return users
+
+    @staticmethod
+    def get_zendesk_users(users):
+        zendesk_users = ZendeskUserSerializer(
+            data=[user for user in users if user.role != 'admin'],
+            many=True
+        )
+        zendesk_users.is_valid()
+        return zendesk_users.data
 
 
 @login_required()