#71 | Тесты Получения Прав Легкого Агента

fixtures/test_users.json

@@ -51,7 +51,7 @@
       "name": "UserForAccessTest",
       "user": 2,
       "role": "agent",
-      "custom_role_id": "360005209000"
+      "custom_role_id": "360005208980"
     }
   },
   {

main/tests.py

@@ -13,6 +13,23 @@ import access_controller.settings as sets
 from main.zendesk_admin import zenpy
 
 
+class UsersBaseTestCase(TestCase):
+    """Базовый класс загружения данных для тестов с пользователями"""
+    fixtures = ['fixtures/test_users.json']
+
+    def setUp(self):
+        """Добавление в переменные почт и клиентов для пользователей"""
+        self.light_agent = '123@test.ru'
+        self.admin = 'admin@gmail.com'
+        self.engineer = 'customer@example.com'
+        self.agent_client = Client()
+        self.agent_client.force_login(User.objects.get(email=self.light_agent))
+        self.admin_client = Client()
+        self.admin_client.force_login(User.objects.get(email=self.admin))
+        self.engineer_client = Client()
+        self.engineer_client.force_login(User.objects.get(email=self.engineer))
+
+
 class RegistrationTestCase(TestCase):
     fixtures = ['fixtures/data.json']
 
@@ -67,55 +84,43 @@ class RegistrationTestCase(TestCase):
         self.assertTrue(user.has_perm('main.has_control_access'))
 
 
-class MakeEngineerTestCase(TestCase):
+class MakeEngineerTestCase(UsersBaseTestCase):
-    fixtures = ['fixtures/test_make_engineer.json']
-
-    def setUp(self):
-        self.light_agent = '123@test.ru'
-        self.admin = 'admin@gmail.com'
-        self.engineer = 'customer@example.com'
-        self.client = Client()
-        self.client.force_login(User.objects.get(email=self.light_agent))
-        self.admin_client = Client()
-        self.admin_client.force_login(User.objects.get(email=self.admin))
 
     @patch('main.extra_func.zenpy')
-    def test_redirect(self, ZenpyMock):
+    def test_become_engineer_redirect(self, _zenpy_mock):
         user = User.objects.get(email=self.light_agent)
-        resp = self.client.post(reverse_lazy('work_become_engineer'))
+        resp = self.agent_client.post(reverse_lazy('work_become_engineer'))
         self.assertRedirects(resp, reverse('work', args=[user.id]))
         self.assertEqual(resp.status_code, 302)
 
     @patch('main.extra_func.zenpy')
-    def test_light_agent_make_engineer(self, ZenpyMock):
+    def test_light_agent_make_engineer(self, zenpy_mock):
-        self.client.post(reverse_lazy('work_become_engineer'))
+        self.agent_client.post(reverse_lazy('work_become_engineer'))
-        self.assertEqual(ZenpyMock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['engineer'])
+        self.assertEqual(zenpy_mock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['engineer'])
 
     @patch('main.extra_func.zenpy')
-    def test_admin_make_engineer(self, ZenpyMock):
+    def test_admin_make_engineer(self, zenpy_mock):
         self.admin_client.post(reverse_lazy('work_become_engineer'))
-        self.assertEqual(ZenpyMock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['engineer'])
+        self.assertEqual(zenpy_mock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['engineer'])
 
     @patch('main.extra_func.zenpy')
-    def test_engineer_make_engineer(self, ZenpyMock):
+    def test_engineer_make_engineer(self, zenpy_mock):
-        client = Client()
+        self.engineer_client.post(reverse_lazy('work_become_engineer'))
-        client.force_login(User.objects.get(email=self.engineer))
+        self.assertEqual(zenpy_mock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['engineer'])
-        client.post(reverse_lazy('work_become_engineer'))
-        self.assertEqual(ZenpyMock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['engineer'])
 
     @patch('main.extra_func.zenpy')
-    def test_control_page_make_one(self, ZenpyMock):
+    def test_control_page_make_engineer_one(self, zenpy_mock):
         self.admin_client.post(
             reverse_lazy('control'),
             data={'users': [User.objects.get(email=self.light_agent).userprofile.id], 'engineer': 'engineer'}
         )
-        call_list = ZenpyMock.update_user.call_args_list
+        call_list = zenpy_mock.update_user.call_args_list
         mock_object = call_list[0][0][0]
         self.assertEqual(len(call_list), 1)
         self.assertEqual(mock_object.custom_role_id, sets.ZENDESK_ROLES['engineer'])
 
     @patch('main.extra_func.zenpy')
-    def test_control_page_make_many(self, ZenpyMock):
+    def test_control_page_make_engineer_many(self, zenpy_mock):
         self.admin_client.post(
             reverse_lazy('control'),
             data={
@@ -126,35 +131,120 @@ class MakeEngineerTestCase(TestCase):
                 'engineer': 'engineer'
             }
         )
-        call_list = ZenpyMock.update_user.call_args_list
+        call_list = zenpy_mock.update_user.call_args_list
         mock_objects = list(call_list)
         self.assertEqual(len(call_list), 2)
         for obj in mock_objects:
             self.assertEqual(obj[0][0].custom_role_id, sets.ZENDESK_ROLES['engineer'])
 
 
-class PasswordResetTestCase(TestCase):
+class MakeLightAgentTestCase(UsersBaseTestCase):
-    fixtures = ['fixtures/test_make_engineer.json']
+
+    @patch('main.requester.TicketListRequester.get_tickets_list_for_user', side_effect=[[]])
+    @patch('main.extra_func.zenpy')
+    def test_hand_over_redirect(self, _zenpy_mock, _user_tickets_mock):
+        user = User.objects.get(email=self.engineer)
+        resp = self.engineer_client.post(reverse_lazy('work_hand_over'))
+        self.assertRedirects(resp, reverse('work', args=[user.id]))
+        self.assertEqual(resp.status_code, 302)
+
+    @patch('main.requester.TicketListRequester.get_tickets_list_for_user', side_effect=[[]])
+    @patch('main.extra_func.zenpy')
+    def test_engineer_make_light_agent_no_tickets(self, zenpy_mock, _user_tickets_mock):
+        self.engineer_client.post(reverse_lazy('work_hand_over'))
+        self.assertEqual(zenpy_mock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['light_agent'])
+
+    @patch('main.requester.TicketListRequester.get_tickets_list_for_user', side_effect=[
+        [Mock(id=1, status='solved'), Mock(id=2, status='open'), Mock(id=3, status='open')]
+    ])
+    @patch('main.extra_func.zenpy')
+    def test_engineer_make_light_agent_with_tickets(self, zenpy_mock, _user_tickets_mock):
+        zenpy_mock.solved_tickets_user_id = Mock()
+        self.engineer_client.post(reverse_lazy('work_hand_over'))
+
+        tickets_update = zenpy_mock.admin.tickets.update.call_args[0][0]
+        self.assertEqual(tickets_update[0].assignee_id, zenpy_mock.solved_tickets_user_id)
+        self.assertIsNone(tickets_update[1].assignee)
+        self.assertIsNone(tickets_update[2].assignee)
+        self.assertEqual(zenpy_mock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['light_agent'])
+
+    @patch('main.requester.TicketListRequester.get_tickets_list_for_user', side_effect=[[]])
+    @patch('main.extra_func.zenpy')
+    def test_admin_make_light_agent_no_tickets(self, zenpy_mock, _user_tickets_mock):
+        self.admin_client.post(reverse_lazy('work_hand_over'))
+        self.assertEqual(zenpy_mock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['light_agent'])
+
+    @patch('main.requester.TicketListRequester.get_tickets_list_for_user', side_effect=[
+        [Mock(id=1, status='solved'), Mock(id=2, status='open'), Mock(id=3, status='open')]
+    ])
+    @patch('main.extra_func.zenpy')
+    def test_admin_make_light_agent_with_tickets(self, zenpy_mock, _user_tickets_mock):
+        zenpy_mock.solved_tickets_user_id = Mock()
+        self.admin_client.post(reverse_lazy('work_hand_over'))
+
+        tickets_update = zenpy_mock.admin.tickets.update.call_args[0][0]
+        self.assertEqual(tickets_update[0].assignee_id, zenpy_mock.solved_tickets_user_id)
+        self.assertIsNone(tickets_update[1].assignee)
+        self.assertIsNone(tickets_update[2].assignee)
+        self.assertEqual(zenpy_mock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['light_agent'])
+
+    @patch('main.requester.TicketListRequester.get_tickets_list_for_user', side_effect=[[]])
+    @patch('main.extra_func.zenpy')
+    def test_light_agent_make_light_agent(self, zenpy_mock, _user_tickets_mock):
+        self.agent_client.post(reverse_lazy('work_hand_over'))
+        self.assertEqual(zenpy_mock.update_user.call_args[0][0].custom_role_id, sets.ZENDESK_ROLES['light_agent'])
+
+    @patch('main.requester.TicketListRequester.get_tickets_list_for_user', side_effect=[[]])
+    @patch('main.extra_func.zenpy')
+    def test_control_page_make_light_agent_one(self, zenpy_mock, _user_tickets_mock):
+        self.admin_client.post(
+            reverse_lazy('control'),
+            data={'users': [User.objects.get(email=self.engineer).userprofile.id], 'light_agent': 'light_agent'}
+        )
+        call_list = zenpy_mock.update_user.call_args_list
+        mock_object = call_list[0][0][0]
+        self.assertEqual(len(call_list), 1)
+        self.assertEqual(mock_object.custom_role_id, sets.ZENDESK_ROLES['light_agent'])
+
+    @patch('main.requester.TicketListRequester.get_tickets_list_for_user', side_effect=[[], []])
+    @patch('main.extra_func.zenpy')
+    def test_control_page_make_light_agent_many(self, zenpy_mock, _user_tickets_mock):
+        self.admin_client.post(
+            reverse_lazy('control'),
+            data={
+                'users': [
+                    User.objects.get(email=self.light_agent).userprofile.id,
+                    User.objects.get(email=self.engineer).userprofile.id,
+                ],
+                'light_agent': 'light_agent'
+            }
+        )
+        call_list = zenpy_mock.update_user.call_args_list
+        mock_objects = list(call_list)
+        self.assertEqual(len(call_list), 2)
+        for obj in mock_objects:
+            self.assertEqual(obj[0][0].custom_role_id, sets.ZENDESK_ROLES['light_agent'])
+
+
+class PasswordResetTestCase(UsersBaseTestCase):
 
     def setUp(self):
-        self.user = '123@test.ru'
+        super().setUp()
         self.email_backend = 'django.core.mail.backends.locmem.EmailBackend'
-        self.client = Client()
-        self.client.force_login(User.objects.get(email=self.user))
 
     def test_redirect(self):
         with self.settings(EMAIL_BACKEND=self.email_backend):
-            resp = self.client.post(reverse_lazy('password_reset'), data={'email': self.user})
+            resp = self.agent_client.post(reverse_lazy('password_reset'), data={'email': self.light_agent})
         self.assertRedirects(resp, reverse('password_reset_done'))
         self.assertEqual(resp.status_code, 302)
 
     def test_send_email(self):
         with self.settings(EMAIL_BACKEND=self.email_backend):
             response: HttpResponseRedirect = \
-                self.client.post(reverse_lazy('password_reset'), data={'email': self.user})
+                self.agent_client.post(reverse_lazy('password_reset'), data={'email': self.light_agent})
         self.assertEqual(response.status_code, 302)
         self.assertEqual(len(mail.outbox), 1)
-        self.assertEqual(mail.outbox[0].to, [self.user])
+        self.assertEqual(mail.outbox[0].to, [self.light_agent])
 
         # context that the email template was rendered with
         email_context = response.context[0].dicts[1]
@@ -165,34 +255,31 @@ class PasswordResetTestCase(TestCase):
 
     def test_email_invalid(self):
         with self.settings(EMAIL_BACKEND=self.email_backend) and translation.override('ru'):
-            resp = self.client.post(reverse_lazy('password_reset'), data={'email': 1})
+            resp = self.agent_client.post(reverse_lazy('password_reset'), data={'email': 1})
         self.assertContains(resp, 'Введите правильный адрес электронной почты.', count=1, status_code=200)
 
     def test_user_does_not_exist(self):
         with self.settings(EMAIL_BACKEND=self.email_backend):
-            resp = self.client.post(reverse_lazy('password_reset'), data={'email': self.user + str(random.random())})
+            resp = self.agent_client.post(reverse_lazy('password_reset'), data={'email': self.light_agent + str(random.random())})
         self.assertRedirects(resp, reverse('password_reset_done'))
         self.assertEqual(resp.status_code, 302)
         self.assertEqual(len(mail.outbox), 0)
 
 
-class PasswordChangeTestCase(TestCase):
+class PasswordChangeTestCase(UsersBaseTestCase):
-    fixtures = ['fixtures/test_make_engineer.json']
 
     def setUp(self):
-        self.user = '123@test.ru'
+        super().setUp()
-        self.client = Client()
-        self.client.force_login(User.objects.get(email=self.user))
         self.set_password()
 
     def set_password(self):
-        user: User = User.objects.get(email=self.user)
+        user: User = User.objects.get(email=self.light_agent)
         user.set_password('ImpossiblyHardPassword')
         user.save()
-        self.client.force_login(User.objects.get(email=self.user))
+        self.agent_client.force_login(User.objects.get(email=self.light_agent))
 
     def test_change_successful(self):
-        self.client.post(
+        self.agent_client.post(
             reverse_lazy('password_change'),
             data={
                 'old_password': 'ImpossiblyHardPassword',
@@ -200,12 +287,12 @@ class PasswordChangeTestCase(TestCase):
                 'new_password2': 'EasyPassword',
             }
         )
-        user = User.objects.get(email=self.user)
+        user = User.objects.get(email=self.light_agent)
         self.assertTrue(user.check_password('EasyPassword'))
 
     def test_invalid_old_password(self):
         with translation.override('ru'):
-            resp = self.client.post(
+            resp = self.agent_client.post(
                 reverse_lazy('password_change'),
                 data={
                     'old_password': 'EasyPassword',
@@ -217,7 +304,7 @@ class PasswordChangeTestCase(TestCase):
 
     def test_different_new_passwords(self):
         with translation.override('ru'):
-            resp = self.client.post(
+            resp = self.agent_client.post(
                 reverse_lazy('password_change'),
                 data={
                     'old_password': 'ImpossiblyHardPassword',
@@ -229,7 +316,7 @@ class PasswordChangeTestCase(TestCase):
 
     def test_invalid_new_password1(self):
         with translation.override('ru'):
-            resp = self.client.post(
+            resp = self.agent_client.post(
                 reverse_lazy('password_change'),
                 data={
                     'old_password': 'ImpossiblyHardPassword',
@@ -241,7 +328,7 @@ class PasswordChangeTestCase(TestCase):
 
     def test_invalid_new_password2(self):
         with translation.override('ru'):
-            resp = self.client.post(
+            resp = self.agent_client.post(
                 reverse_lazy('password_change'),
                 data={
                     'old_password': 'ImpossiblyHardPassword',
@@ -253,104 +340,92 @@ class PasswordChangeTestCase(TestCase):
 
     def test_invalid_new_password3(self):
         with translation.override('ru'):
-            resp = self.client.post(
+            resp = self.agent_client.post(
                 reverse_lazy('password_change'),
                 data={
                     'old_password': 'ImpossiblyHardPassword',
-                    'new_password1': self.user,
+                    'new_password1': self.light_agent,
-                    'new_password2': self.user,
+                    'new_password2': self.light_agent,
                 }
             )
         self.assertContains(resp, 'Введённый пароль слишком похож на имя пользователя', count=1, status_code=200)
 
 
-class GetTicketsTestCase(TestCase):
+class GetTicketsTestCase(UsersBaseTestCase):
     """
     Класс тестов для проверки функции получения тикетов.
     """
-    fixtures = ['fixtures/test_make_engineer.json']
-
-    def setUp(self):
-        """
-        Предустановленные значения для проведения тестов.
-        """
-        self.light_agent = '123@test.ru'
-        self.engineer = 'customer@example.com'
-        self.client = Client()
-        self.client.force_login(User.objects.get(email=self.engineer))
-        self.light_agent_client = Client()
-        self.light_agent_client.force_login(User.objects.get(email=self.light_agent))
 
     @patch('main.views.zenpy.get_user')
     @patch('main.extra_func.zenpy')
-    def test_redirect(self, ZenpyMock, GetUserMock):
+    def test_redirect(self, _zenpy_mock, get_user_mock):
         """
         Функция проверки переадресации пользователя на рабочую страницу.
         """
-        GetUserMock.return_value = Mock()
+        get_user_mock.return_value = Mock()
         user = User.objects.get(email=self.engineer)
-        resp = self.client.post(reverse('work_get_tickets'))
+        resp = self.engineer_client.post(reverse('work_get_tickets'))
         self.assertRedirects(resp, reverse('work', args=[user.id]))
         self.assertEqual(resp.status_code, 302)
 
     @patch('main.views.zenpy')
     @patch('main.views.get_tickets_list_for_group')
-    def test_take_one_ticket(self, TicketsMock, ZenpyViewsMock):
+    def test_take_one_ticket(self, group_tickets_mock, zenpy_mock):
         """
         Функция проверки назначения одного тикета на engineer.
         """
-        TicketsMock.return_value = [Mock()]
+        group_tickets_mock.return_value = [Mock()]
-        ZenpyViewsMock.get_user.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['engineer'])
+        zenpy_mock.get_user.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['engineer'])
-        self.client.post(reverse('work_get_tickets'), data={'count_tickets': 1})
+        self.engineer_client.post(reverse('work_get_tickets'), data={'count_tickets': 1})
-        tickets = ZenpyViewsMock.update_tickets.call_args
+        tickets = zenpy_mock.update_tickets.call_args
-        self.assertEqual(tickets[0][0][0].assignee, ZenpyViewsMock.get_user.return_value)
+        self.assertEqual(tickets[0][0][0].assignee, zenpy_mock.get_user.return_value)
 
     @patch('main.views.get_tickets_list_for_group')
     @patch('main.views.zenpy')
-    def test_take_many_tickets(self, ZenpyMock, TicketsMock):
+    def test_take_many_tickets(self, zenpy_mock, group_tickets_mock):
         """
         Функция проверки назначения нескольких тикетов на engineer.
         """
-        TicketsMock.return_value = [Mock()] * 3
+        group_tickets_mock.return_value = [Mock()] * 3
-        ZenpyMock.get_user.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['engineer'])
+        zenpy_mock.get_user.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['engineer'])
-        self.client.post(reverse('work_get_tickets'), data={'count_tickets': 3})
+        self.engineer_client.post(reverse('work_get_tickets'), data={'count_tickets': 3})
-        tickets = ZenpyMock.update_tickets.call_args
+        tickets = zenpy_mock.update_tickets.call_args
         for ticket in tickets[0][0]:
-            self.assertEqual(ticket.assignee, ZenpyMock.get_user.return_value)
+            self.assertEqual(ticket.assignee, zenpy_mock.get_user.return_value)
 
     @patch('main.views.zenpy.get_user')
     @patch('main.views.zenpy')
-    def test_light_agent_take_ticket(self, ZenpyMock, GetUserMock):
+    def test_light_agent_take_ticket(self, zenpy_mock, get_user_mock):
         """
         Функция проверки попытки назначения тикета на light_agent.
         """
-        GetUserMock.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['light_agent'])
+        get_user_mock.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['light_agent'])
-        self.light_agent_client.post(reverse('work_get_tickets'), data={'count_tickets': 3})
+        self.agent_client.post(reverse('work_get_tickets'), data={'count_tickets': 3})
-        tickets = ZenpyMock.update_tickets.call_args
+        tickets = zenpy_mock.update_tickets.call_args
         self.assertIsNone(tickets)
 
     @patch('main.views.zenpy')
     @patch('main.views.get_tickets_list_for_group')
-    def test_take_zero_tickets(self, TicketsMock, ZenpyMock):
+    def test_take_zero_tickets(self, TicketsMock, zenpy_mock):
         """
         Функция проверки попытки назначения нуля тикета на engineer.
         """
         TicketsMock.return_value = [Mock()] * 3
-        ZenpyMock.get_user.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['engineer'])
+        zenpy_mock.get_user.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['engineer'])
-        self.client.post(reverse('work_get_tickets'), data={'count_tickets': 0})
+        self.engineer_client.post(reverse('work_get_tickets'), data={'count_tickets': 0})
-        tickets = ZenpyMock.update_tickets.call_args[0][0]
+        tickets = zenpy_mock.update_tickets.call_args[0][0]
         self.assertListEqual(tickets, [])
 
     @patch('main.views.get_tickets_list_for_group')
     @patch('main.views.zenpy')
-    def test_take_invalid_count_tickets(self, ZenpyMock, TicketsMock, ):
+    def test_take_invalid_count_tickets(self, zenpy_mock, group_tickets_mock):
         """
         Функция проверки попытки назначения нуля тикетов на engineer.
         """
-        TicketsMock.return_value = [Mock()] * 3
+        group_tickets_mock.return_value = [Mock()] * 3
-        ZenpyMock.get_user.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['engineer'])
+        zenpy_mock.get_user.return_value = Mock(role='agent', custom_role_id=sets.ZENDESK_ROLES['engineer'])
-        self.client.post(reverse('work_get_tickets'), data={'count_tickets': 'asd'})
+        self.engineer_client.post(reverse('work_get_tickets'), data={'count_tickets': 'asd'})
-        tickets = ZenpyMock.update_tickets.call_args
+        tickets = zenpy_mock.update_tickets.call_args
         self.assertIsNone(tickets)